Re: (Modified) Patch request for PostgreSQL 7.4 for HP-UX IA-64

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "ViSolve Open Source Team" <opensrc_support_hp(at)visolve(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: (Modified) Patch request for PostgreSQL 7.4 for HP-UX IA-64
Date: 2003-12-23 23:02:02
Message-ID: 8592.1072220522@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

"ViSolve Open Source Team" <opensrc_support_hp(at)visolve(dot)com> writes:
> this is a modified and more focussed patch request for PostgreSQL for for H=
> P-UX
> 11i V2 for the Intel Itanium architecture (known to the PostgreSQL code as
> IA-64).=20

I looked into applying the TAS part of this patch now that Bruce has
finished revising the TAS code, but I do not believe it is right.
The tas() routine looks reasonable, but not this:

> +#define S_UNLOCK(lock) \
> + ( \
> + _Asm_mov_to_ar((_Asm_app_reg)_AREG_CCV, 1UL),\
> + (_Asm_cmpxchg((_Asm_sz)_SZ_W, _SEM_REL, \
> + (volatile slock_t*)lock, \
> + 0UL, (_Asm_ldhint)_LDHINT_NONE, \
> + (_UP_MEM_FENCE|_DOWN_MEM_FENCE)) =3D=3D 1) ? 1 : 0 \
> + )

In the first place, S_UNLOCK does not return a value. In the second,
I doubt that you need an xchg instruction at all --- can't you just
assign zero? (If you can't, then the gcc IA64 code is wrong,
because it uses the default version of S_UNLOCK.)

> +#define S_LOCK_FREE(lock) ( *(volatile slock_t*)(lock))

This is wrong too, unless you're not using the convention that zero
indicates a free lock.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message aarjan langereis 2003-12-24 09:49:40 Re: BUG #1015: Got a signal 11 while trying to create a temp table
Previous Message Kris Jurka 2003-12-23 21:10:25 Re: BUG #1026: org.apache.commons.dbcp.DbcpException: The

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-12-23 23:13:00 Fix for \dn and temp schemas
Previous Message Bruce Momjian 2003-12-23 22:13:29 Re: Quoting of psql \d output