From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
Date: | 2005-06-05 04:45:32 |
Message-ID: | 855.1117946732@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
>> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
>> (But this leak is not serious, because this function is called only once.)
> Does the following patch fix the memory leak you described?
You realize this is a waste of code, no? It's not like the bootstrap
subprocess frees every single bit of memory it ever allocates, and even
less like it'd be profitable to try to make it do so ... the memory
will go away anyway when the subprocess exits.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Russell Smith | 2005-06-05 04:50:55 | Re: WAL bypass for CTAS |
Previous Message | Tom Lane | 2005-06-05 04:17:23 | Re: [PATCHES] WAL bypass for CTAS |
From | Date | Subject | |
---|---|---|---|
Next Message | Russell Smith | 2005-06-05 04:50:55 | Re: WAL bypass for CTAS |
Previous Message | Tom Lane | 2005-06-05 04:17:23 | Re: [PATCHES] WAL bypass for CTAS |