| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory |
| Date: | 2005-06-05 03:40:48 |
| Message-ID: | 200506050340.j553emJ06333@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
ITAGAKI Takahiro wrote:
> Hello everyone.
>
> I fixed two bugs in the patch that I sent before.
> Check and test new one, please.
>
> 1. Fix update timing of Write->curridx. (pointed by Tom)
> Change to update it soon after write().
>
> 2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
> I checked it on Xeon EM64T and it worked properly, but I don't have IA64...
>
>
> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
> (But this leak is not serious, because this function is called only once.)
Does the following patch fix the memory leak you described?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 519 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-06-05 03:42:51 | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ |
| Previous Message | Bruce Momjian | 2005-06-05 03:37:14 | Re: Server instrumentation for 8.1 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-06-05 03:42:51 | Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ |
| Previous Message | Bruce Momjian | 2005-06-05 03:16:26 | Re: return_next for plperl |