| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgcrypto.sgml: built in -> built-in |
| Date: | 2026-08-25 08:45:08 |
| Message-ID: | 844B4157-0096-4D2F-9DF2-D79ACBB2E63A@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 16 Aug 2026, at 22:16, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 16 Aug 2026, at 18:21, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>> On 2026-Aug-16, Erik Rijkers wrote:
>
>>> The documentation contains the word 'built-in' (with hyphen) more than 200
>>> times so let's correct the 2x 'built in' in doc/src/sgml/pgcrypto.sgml
>>
>> Well observed.
>
> Ugh, that's my bad.
>
>> We do have "builtin" a number of times though. Do we
>> want to change those too? For example
>>
>> contrib/pgcrypto/pgcrypto.c- DefineCustomEnumVariable("pgcrypto.builtin_crypto_enabled",
>> contrib/pgcrypto/pgcrypto.c: "Sets if builtin crypto functions are enabled.",
>> contrib/pgcrypto/pgcrypto.c: "\"on\" enables builtin crypto, \"off\" unconditionally disables and \"fips\" "
>> contrib/pgcrypto/pgcrypto.c: "will disable builtin crypto if OpenSSL is in FIPS mode",
>> contrib/pgcrypto/pgcrypto.c- &builtin_crypto_enabled,
>
> Another one of mine =( This one should be the same as the in the docs IMHO.
Since pgcrypto is its own module I pushed the pgcrypto changes for docs and GUC
on their own.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-08-25 08:46:13 | RE: Patch for migration of the pg_commit_ts directory |
| Previous Message | Peter Eisentraut | 2026-08-25 08:42:34 | Re: fix more casting away of qualifiers |