Re: pgcrypto.sgml: built in -> built-in

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgcrypto.sgml: built in -> built-in
Date: 2026-08-16 20:16:16
Message-ID: 3A050087-0BBE-4A0E-9532-D0D7BA07DB00@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 16 Aug 2026, at 18:21, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> On 2026-Aug-16, Erik Rijkers wrote:

>> The documentation contains the word 'built-in' (with hyphen) more than 200
>> times so let's correct the 2x 'built in' in doc/src/sgml/pgcrypto.sgml
>
> Well observed.

Ugh, that's my bad.

> We do have "builtin" a number of times though. Do we
> want to change those too? For example
>
> contrib/pgcrypto/pgcrypto.c- DefineCustomEnumVariable("pgcrypto.builtin_crypto_enabled",
> contrib/pgcrypto/pgcrypto.c: "Sets if builtin crypto functions are enabled.",
> contrib/pgcrypto/pgcrypto.c: "\"on\" enables builtin crypto, \"off\" unconditionally disables and \"fips\" "
> contrib/pgcrypto/pgcrypto.c: "will disable builtin crypto if OpenSSL is in FIPS mode",
> contrib/pgcrypto/pgcrypto.c- &builtin_crypto_enabled,

Another one of mine =( This one should be the same as the in the docs IMHO.

> --
> contrib/postgres_fdw/deparse.c- * If the constant has nondefault collation, either it's of a
> contrib/postgres_fdw/deparse.c: * non-builtin type, or it reflects folding of a CollateExpr.
> contrib/postgres_fdw/deparse.c- * It's unsafe to send to the remote unless it's used in a
> --
> contrib/postgres_fdw/option.c- /*
> contrib/postgres_fdw/option.c: * Disallow OAuth options for now, since the builtin flow communicates
> contrib/postgres_fdw/option.c- * on stderr by default and can't cache tokens yet.
> --
> contrib/test_decoding/test_decoding.c- *
> contrib/test_decoding/test_decoding.c: * Some builtin types aren't quoted, the rest is quoted. Escaping is done
> contrib/test_decoding/test_decoding.c- * per standard SQL rules.

Personally I'm not to worried about spelling fixes at this level in comments,
but the risk of causing backpatching pain is low so if someone wants to do the
work then thats all good.

> doc/src/sgml/jit.sgml- <para>
> doc/src/sgml/jit.sgml: <productname>PostgreSQL</productname> has builtin support to perform
> doc/src/sgml/jit.sgml- <acronym>JIT</acronym> compilation using <ulink
> --
> doc/src/sgml/libpq.sgml- installation documentation</link> for information on how to enable support
> doc/src/sgml/libpq.sgml: for Device Authorization as a builtin flow.
> doc/src/sgml/libpq.sgml- </para>

+1 on these.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-08-16 20:26:57 Re: Residual cleanups for tied objects in PL/Perl
Previous Message Andrey Rachitskiy 2026-08-16 20:08:07 Re: Residual cleanups for tied objects in PL/Perl