Re: Random inconsistencies in GiST support function declarations

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> This work (9ff60273e35cad6e9) seems have broken pg_upgrade when
> tsearch2 is installed.

> On an empty 9.4 instance with nothing but tsearch2 installed, using
> HEAD's pg_upgrade gives this error:

> pg_restore: creating OPERATOR CLASS "public.gin_tsvector_ops"
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
> pg_restore: [archiver (db)] Error from TOC entry 3037; 2616 19016
> OPERATOR CLASS gist_tp_tsquery_ops jjanes
> pg_restore: [archiver (db)] could not execute query: ERROR: function
> gtsquery_consistent(internal, internal, integer, oid, internal) does
> not exist
> Command was: CREATE OPERATOR CLASS "gist_tp_tsquery_ops"
> FOR TYPE "pg_catalog"."tsquery" USING "gist" AS
> STORAGE bigint ,
> OPE...

Ah, drat. I guess we'll have to continue to provide pg_proc entries with
the old signatures to support pg_upgrade. Will fix.

regards, tom lane