Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path
Date: 2025-10-13 21:59:37
Message-ID: 828188.1760392777@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bryan Green <dbryan(dot)green(at)gmail(dot)com> writes:
> The problem:
> - FRONTEND path: fprintf(stderr, fmt, ap) - incorrect
> - non-FRONTEND path: write_stderr(fmt, ap) - also incorrect

> The first patch only addressed the fprintf issue. The v2 patch
> addresses both.

Actually, you'd managed to drop the fprintf->vfprintf change :-(.
I fixed that, pgindent'd it, wordsmithed the commit message,
and pushed. Many thanks for finding this!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-10-13 22:08:43 Re: Fixed a typo in comment in compress_lz4.c
Previous Message Chao Li 2025-10-13 21:51:17 Re: Fixed a typo in comment in compress_lz4.c