Re: Fixed a typo in comment in compress_lz4.c

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixed a typo in comment in compress_lz4.c
Date: 2025-10-13 21:51:17
Message-ID: 41B9A29C-0FD4-4DC8-A0F5-243CB57A2819@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Oct 14, 2025, at 05:31, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 13 Oct 2025, at 23:25, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>> Fixed a typo: "iff" -> "if" that I found while reviewing the other patch.
>
> iff is shorthand for "if and only if", so it is correct here. That being said,
> it's also the cause of many typofix suggstions so it's clearly not widely known
> anymore and we try to avoid it new code/comments. Maybe a case could be made
> for changing all the iff's in the code to aid readability, but it would have to
> be measured against the induced churn.
>
> --
> Daniel Gustafsson
>

Oh… I was misled by [1]. I should have done a Google search for that by myself.

I just did a search and found 219 occurrences:

```
chaol(at)ChaodeMacBook-Air postgresql % grep -Rho --include='*.c' --include='*.h' ' iff' . | wc -l
219
```

Do you think it is worth replacing all in a batch?

[1] https://www.postgresql.org/message-id/CAKFQuwa6jgVj18bRGE3edy2Z%3D5%3DDAUGL8efxG2KdWJg12nF0kw%40mail.gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-10-13 21:59:37 Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path
Previous Message Masahiko Sawada 2025-10-13 21:48:53 Re: Support getrandom() for pg_strong_random() source