Re: pgsql: Add pg_alterckey utility to change the cluster key

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add pg_alterckey utility to change the cluster key
Date: 2020-12-28 13:49:09
Message-ID: 8213f11d-ee4a-1e60-fd66-2435407221a5@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 12/27/20 12:44 PM, Bruce Momjian wrote:
>
>> Based on the number of concerns raised by various people over the last
>> couple of days (including myself, one point being the refactoring of
>> the ciphers taken from pgcrypto that should have been in its own
>> commit), I agree that it would be better to revert this code for now.
> OK, I will do so in the next few hours. My followup will be to:
>
> * register it for the commit-fest so it gets cfbot and other visibility
> * modify pgcrypto to use the new AES API (the SHA512 call no longer exists)
> * develop TAP tests, though as I mentioned, they will be odd
>

Bruce

I think this is a wise course.

The cfbot and the vanilla buildfarm can't test some things easily, and
this might be such a case. That's where custom buildfarm modules can
prove useful. For example, we have one that is used by rhinoceros to run
the SEPgsql tests. ISTM this might well be another case. I can work with
you to develop such a module.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2020-12-28 14:09:11 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message Michael Paquier 2020-12-28 13:19:08 pgsql: Fix inconsistent code with shared invalidations of snapshots

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2020-12-28 14:09:11 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message Arne Roland 2020-12-28 13:01:50 Re: a misbehavior of partition row movement (?)