Re: pgsql: Add pg_alterckey utility to change the cluster key

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add pg_alterckey utility to change the cluster key
Date: 2020-12-28 15:34:00
Message-ID: 20201228153400.GB1697@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Dec 28, 2020 at 08:49:09AM -0500, Andrew Dunstan wrote:
>
> On 12/27/20 12:44 PM, Bruce Momjian wrote:
> >
> >> Based on the number of concerns raised by various people over the last
> >> couple of days (including myself, one point being the refactoring of
> >> the ciphers taken from pgcrypto that should have been in its own
> >> commit), I agree that it would be better to revert this code for now.
> > OK, I will do so in the next few hours. My followup will be to:
> >
> > * register it for the commit-fest so it gets cfbot and other visibility
> > * modify pgcrypto to use the new AES API (the SHA512 call no longer exists)
> > * develop TAP tests, though as I mentioned, they will be odd
> >
>
> Bruce
>
> I think this is a wise course.
>
> The cfbot and the vanilla buildfarm can't test some things easily, and
> this might be such a case. That's where custom buildfarm modules can
> prove useful. For example, we have one that is used by rhinoceros to run
> the SEPgsql tests. ISTM this might well be another case. I can work with
> you to develop such a module.

Oh, wow, I never considered that would be possible. I think we are OK
not having automation of the Yubikey and AWS scripts, since they are
small and rarely change. I think we can get the rest done with normal
buildfarm members.

I am going to use the pg_upgrade TAP test as an example since it has
similar requirements and prior to its creation, I did my own testing of
that. I am not sure how to test prompting from /dev/tty.

Seems I am behind the times in learning how to write TAP tests and use
the buildfarm cfbot testing properly.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-28 15:39:51 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message Tom Lane 2020-12-28 15:11:40 Re: pgsql: Fix memory leak in plpgsql's CALL processing.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-28 15:39:51 Re: pgsql: Add pg_alterckey utility to change the cluster key
Previous Message Tom Lane 2020-12-28 15:11:40 Re: pgsql: Fix memory leak in plpgsql's CALL processing.