| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Subject: | Re: Show 'Rows Removed by Filter' with two fractional digits in EXPLAIN |
| Date: | 2026-11-09 22:59:40 |
| Message-ID: | 81da377f-96dc-41f3-a822-49c5fbea565e@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/11/2026 14:28, Robert Haas wrote:
> On Fri, Nov 6, 2026 at 3:57 AM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
>> 1. Always print two digits, as actual rows do now.
>> 2. Leave the math to users and print exact totals without dividing by nloops.
>
> I think we should do #1. Dividing by nloops is never what I personally
> want for any of these, but we got enough consensus on it to move
> forward with it for the actual row counts, so I think doing the same
> thing here makes sense to me. Maybe eventually we will get consensus
> on other changes, but I think we probably don't have it now, and doing
> what we can do is better than arguing a case we probably won't win.
>
Ok, agreed.
Here's the next version of the patch. It passed 'make check-world' on the
current master (c074737f687).
--
regards, Andrei Lepikhov,
pgEdge
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Use-two-fractional-digits-for-row-filters.patch | text/plain | 28.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | surya poondla | 2026-11-09 23:13:39 | Re: Parallel vacuum: check XID wraparound failsafe between indexes |
| Previous Message | Rafael Chacón | 2026-11-09 21:11:19 | Re: Table synchronization cannot resume after a subscriber crash |