Re: Show 'Rows Removed by Filter' with two fractional digits in EXPLAIN

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Andrei Lepikhov <lepihov(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Show 'Rows Removed by Filter' with two fractional digits in EXPLAIN
Date: 2026-11-10 07:12:39
Message-ID: 27a8098c-218d-41ad-91ca-c88cfab38190@tantorlabs.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/10/26 01:59, Andrei Lepikhov wrote:

> Here's the next version of the patch. It passed 'make check-world' on the
> current master (c074737f687).

One small nit: could we also use a precision of 2 in the else branch of
`nloops > 0`, so that it prints 0.00 rather than 0? Looking at the
changes in [0], its parser will accept both integer and fractional
values, so this suggestion is mainly for consistency.

The rest of the v1-patch looks good to me.

[0]:
https://gitlab.com/depesz/Pg--Explain/-/commit/5281e4ea1b23b1823e47f353055407307727adec#line_c77cc309f_137

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Chao Li 2026-11-10 06:27:39 Re: Clarify wait versus poll behavior in ExecAppendAsyncEventWait