Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

From: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
Subject: Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Date: 2022-09-21 14:41:20
Message-ID: 812aa0fa-3986-4a6d-be50-adcaf523e4ce@Spark
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, wrote:
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless.
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
+1, Good Catch.

Regards,
Zhang Mingli

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-09-21 14:49:12 Re: [PATCH] polish the error message of creating proc
Previous Message Junwang Zhao 2022-09-21 14:35:47 Re: [PATCH] polish the error message of creating proc