Re: [PATCH] polish the error message of creating proc

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] polish the error message of creating proc
Date: 2022-09-21 14:49:12
Message-ID: 20220921144912.widpjlzk27bntu2q@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 21, 2022 at 10:35:47PM +0800, Junwang Zhao wrote:
> On Wed, Sep 21, 2022 at 8:17 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> >
> > You can't put part of the message in parameter, as the resulting string isn't
> > translatable. You should either use "routine" as a generic term or provide 3
> > different full messages.
>
> I noticed that there are some translations under the backend/po directory,
> can we just change
> msgid "function \"%s\" already exists with same argument types"
> to
> msgid "%s \"%s\" already exists with same argument types" ?

The problem is that the parameters are passed as-is, so the final emitted
translated string will be a mix of both languages, which isn't acceptable.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-09-21 14:53:00 Re: ICU for global collation
Previous Message Zhang Mingli 2022-09-21 14:41:20 Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot