Re: Trigger position

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Trigger position
Date: 2021-09-15 12:35:30
Message-ID: 80713837-d77b-dd8d-09bd-d93520a130a2@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 9/15/21 1:40 PM, Tom Lane wrote:
> Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> writes:
>> Alphabetical order of triggers sometimes makes me write a_Recalc or z_Calc
>> to be sure it´ll be the first or the last trigger with same event of that
>> table
>
>> Oracle and SQL Server have FOLLOWS and PRECEDES when defining trigger
>> execution order. Firebird has POSITION, which I like it more.
>
> Color me skeptical: doesn't that introduce more complication without
> fundamentally solving anything? You still don't know which position
> numbers other triggers have used, so it seems like this is just a
> different way to spell the same problem.

I guess one advantage is that it would make the intent of the DDL author
more clear to a reader and that it also makes it more clear to people
new to PostgreSQL that trigger order is something that is important to
reason about.

If those small advantages are worth the complication is another question
(I am skpetical), but if we would implement this I prefer the Firebird
solution over the Oralce/MSSQL solution since the Firebird solution is
simpler while achieving the same thing plus that the Firefird solution
seems like it would be obviously backwards compatible with our current
solution.

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-09-15 12:36:51 Re: Column Filtering in Logical Replication
Previous Message Ranier Vilela 2021-09-15 12:27:02 Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)