Re: Column Filtering in Logical Replication

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Column Filtering in Logical Replication
Date: 2021-09-15 12:36:51
Message-ID: 202109151236.mjrtv25qamvw@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Sep-15, vignesh C wrote:

> I have extracted the parser code and attached it here, so that it will
> be easy to go through. We wanted to support the following syntax as in
> [1]:
> TABLE t1,t2,t3, ALL TABLES IN SCHEMA s1,s2,

Oh, thanks, it looks like this can be useful. We can get the common
grammar done and then rebase all the other patches (I was also just told
about support for sequences in [1]) on top.


> Columns can be added to PublicationObjSpec data structure.

Right. (As a List of String, I imagine.)

> The patch
> Generic_object_type_parser_002_table_schema_publication.patch has the
> changes that were used to handle the parsing. Schema and Relation both
> are different objects, schema is of string type and relation is of
> RangeVar type. While parsing, schema name is parsed in string format
> and relation is parsed and converted to rangevar type, these objects
> will be then handled accordingly during post processing.

Yeah, I think it'd be cleaner if the node type has two members, something like

typedef struct PublicationObjSpec
NodeTag type;
PublicationObjSpecType pubobjtype; /* type of this publication object */
RangeVar *rv; /* if a table */
String *objname; /* if a schema */
int location; /* token location, or -1 if unknown */
} PublicationObjSpec;

and only one of them is set, the other is NULL, depending on the object type.

Álvaro Herrera 39°49'30"S 73°17'W —

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-09-15 12:47:11 Re: SSL/TLS instead of SSL in docs
Previous Message Andreas Karlsson 2021-09-15 12:35:30 Re: Trigger position