Re: use pg_get_functiondef() in pg_dump

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: use pg_get_functiondef() in pg_dump
Date: 2020-08-15 09:49:53
Message-ID: 7efccdea-8b77-eca8-6ef6-2ef705c29c01@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-08-12 21:54, Robert Haas wrote:
> One problem with this, which I think Tom pointed out before, is that
> it might make it to handle some forward-compatibility problems. In
> other words, if something that the server is generating needs to be
> modified for compatibility with a future release, it's not easy to do
> that. Like if we needed to quote something we weren't previously
> quoting, for example.

We already use a lot of other pg_get_*def functions in pg_dump. Does
this one introduce any fundamentally new problems?

A hypothetical change where syntax that we accept now would no longer be
accepted in a (near-)future version would create a lot of upsetness. I
don't think we'd do it.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2020-08-15 10:02:09 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Peter Eisentraut 2020-08-15 09:41:53 Re: remove some ancient port hacks