| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PG19] Indexes from 18 miss rows after pg_upgrade |
| Date: | 2026-10-30 18:18:48 |
| Message-ID: | 7e6d5bab37ff2ae558dd9394408f9ef1baa18e78.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2026-10-21 at 23:39 -0400, shihao zhong wrote:
> Hi Andreas,
>
> > we have so far never added anything to check.c in pg_upgrade for a
> > case like this.
>
> There is one. In 18, check_for_unicode_update() (b81ffa13e35) warns
> about indexes on lower(), upper(), regexp and normalize() in builtin
> databases when the Unicode version changes.
I don't think I'd like to use that as a precedent for any function
behavior change, it will bloat pg_upgrade with fairly complex queries
that will only get exercised during one cycle. And it will always be
possible to miss some cases (e.g. due to affected code hiding in a SQL
function), so it can give a false sense of security.
I committed the release note changes, and I'll close the open item.
Thank you.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-10-30 18:31:21 | Re: amcheck: detect corruption from the recent snapshot-export bug |
| Previous Message | Greg Burd | 2026-10-30 18:14:25 | Re: ZSTD TOAST compression, and an extensible compression method encoding |