| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Sami Imseih <samimseih(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: queryId constant squashing does not support prepared statements |
| Date: | 2025-05-06 17:37:11 |
| Message-ID: | 7bgybxjhkefkncouteru5agtvocfgqfla3zeklromqd6auz7c3@hweaaffe6lne |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Tue, May 06, 2025 at 11:50:07PM GMT, Junwang Zhao wrote:
> Would it make sense to rename `RecordConstLocation` to something like
> `RecordExpressionLocation` instead?
Yeah, naming is hard. RecordExpressionLocation is somehow more vague,
but I see what you mean, maybe something along these lines would be
indeed a better fit.
> - /* Array of locations of constants that should be removed */
> + /* Array of locations of constants that should be removed and parameters */
> LocationLen *clocations;
>
> should be
>
> + /* Array of locations of constants and parameters that should be removed */
That was clumsy but intentional, because contrary to constants
parameters do not need to be removed. I guess I have to change the
wording a bit to make it clear.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-05-06 17:49:31 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Nathan Bossart | 2025-05-06 16:41:49 | Re: Large expressions in indexes can't be stored (non-TOASTable) |