From: | Andrei Zubkov <zubkov(at)moonset(dot)ru> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
Subject: | Re: Normalization of utility queries in pg_stat_statements |
Date: | 2023-03-06 12:50:55 |
Message-ID: | 7beb722dd016bf54f1c78bfd6d44a684e28da624.camel@moonset.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Michael!
I'm rebasing a patch "Tracking statements entry timestamp in
pg_stat_statements" for applying after this patch. I've noted that
current tests are not quite independent one from another. There is two
statements in the end of user_activity.sql test:
DROP ROLE regress_stats_user1;
DROP ROLE regress_stats_user2;
Those are done after the last pg_stat_statements_reset call in this
test file and thus, those are included in checks of wal.out file:
query
| calls | rows | wal_bytes_generated | wal_records_generated |
wal_records_ge_rows
-----------------------------------------------------------------------
-------+-------+------+---------------------+-----------------------+--
-------------------
DELETE FROM pgss_wal_tab WHERE a > $1
| 1 | 1 | t | t | t
DROP ROLE regress_stats_user1
| 1 | 0 | t | t | t
DROP ROLE regress_stats_user2
| 1 | 0 | t | t | t
Those statements is not related to any WAL tests. It seems a little bit
incorrect to me.
Are we need some changes here?
--
Andrei Zubkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-03-06 13:13:51 | Re: Support logical replication of DDLs |
Previous Message | Daniel Gustafsson | 2023-03-06 12:24:56 | Re: GUC for temporarily disabling event triggers |