Re: meson html:alias vs. html:custom

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: "L(dot) pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: meson html:alias vs. html:custom
Date: 2026-04-24 07:52:34
Message-ID: 7b7cb0a5-29a7-44c6-bcd5-f2fb36c3073d@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 16.04.26 09:46, Nazir Bilal Yavuz wrote:
> Hi,
>
> On Thu, 16 Apr 2026 at 09:26, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>>
>> On 2026-04-14, Nazir Bilal Yavuz wrote:
>>
>>> On Tue, 14 Apr 2026 at 11:08, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>>>
>>>> If I remove the alias_target, then my original command works. What is
>>>> the purpose of this alias?
>>>
>>> I think the main purpose was using these targets with the ninja
>>> command like: 'ninja ${target}'. ninja command doesn't work when the
>>> alias_target() is removed.
>>
>> I think this is kinda silly. I would rather rename the meson target (to, say, do_html) and make the alias reference that, so that both "meson compile html" and "ninja html" would use the alias.
>
> I agree with you. Here is a patch for fixing this problem with your
> suggestion. I added the '-custom' suffix instead of the 'do_' prefix,
> I think this makes it more concrete.

Committed, thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-04-24 08:07:27 Re: pgbench: make verbose error messages thread-safe
Previous Message wenhui qiu 2026-04-24 07:39:00 Re: New vacuum config to avoid anti wraparound vacuums