| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, "L(dot) pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: meson html:alias vs. html:custom |
| Date: | 2026-04-16 07:46:07 |
| Message-ID: | CAN55FZ2RU-V=AVobnfXg-GD6dPBZTb1F+emVQvioCUAN2bUUTA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 16 Apr 2026 at 09:26, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-04-14, Nazir Bilal Yavuz wrote:
>
> > On Tue, 14 Apr 2026 at 11:08, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> >>
> >> If I remove the alias_target, then my original command works. What is
> >> the purpose of this alias?
> >
> > I think the main purpose was using these targets with the ninja
> > command like: 'ninja ${target}'. ninja command doesn't work when the
> > alias_target() is removed.
>
> I think this is kinda silly. I would rather rename the meson target (to, say, do_html) and make the alias reference that, so that both "meson compile html" and "ninja html" would use the alias.
I agree with you. Here is a patch for fixing this problem with your
suggestion. I added the '-custom' suffix instead of the 'do_' prefix,
I think this makes it more concrete.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-meson-Differentiate-top-level-and-custom-targets.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-04-16 07:49:37 | Re: First draft of PG 19 release notes |
| Previous Message | SATYANARAYANA NARLAPURAM | 2026-04-16 07:33:47 | Re: [PATCH] Fix WAIT FOR LSN standby_write/standby_flush for archive recovery cases |