| From: | Manuel Kniep <rapimo(at)adeven(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: PATCH pass PGOPTIONS to pg_regress |
| Date: | 2018-06-01 19:11:10 |
| Message-ID: | 7EF6F1ED-E33C-4E0C-9B02-A889C9F4C31A@adeven.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Am 30.05.2018 um 17:22 schrieb Michael Paquier <michael(at)paquier(dot)xyz>:
>
> On Wed, May 30, 2018 at 12:28:27PM +0300, Ildar Musin wrote:
>> Here extra.conf is implied to be a file in extension's root directory which
>> contains additional server options.
>> This would only work for `make check` though, not `make installcheck`.
>
> REGRESS_OPTS is more widely known for this purpose, and I use it as
> well. Still, I agree that there is no need to add an extra mechanism
> with PGOPTIONS if a feature already exists. One thing which is also
--temp-config is only supported in temp-instance mode which I wanted to avoid
But if you think that this feature is supported enough by this I agree it doesn’t make sense
to add something. I just don’t see any disadvantage in my approach.
Manuel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-06-01 19:13:25 | Re: pg_replication_slot_advance to return NULL instead of 0/0 if slot not advanced |
| Previous Message | Alvaro Herrera | 2018-06-01 19:00:10 | Re: documentation fixes for partition pruning, round two |