Re: pg_replication_slot_advance to return NULL instead of 0/0 if slot not advanced

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_replication_slot_advance to return NULL instead of 0/0 if slot not advanced
Date: 2018-06-01 19:13:25
Message-ID: 20180601191325.GE9004@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 01, 2018 at 02:53:09PM -0400, Michael Paquier wrote:
> Definitely, while the previous patch was around mainly to show where
> things are incorrect, I am attaching a set of patches for HEAD which can
> be used for commit:
> - One patch which addresses the several lock problems and adds some
> instructions about the variables protected by spinlocks for slots in
> use, which should be back-patched.
> - A second patch for HEAD which addresses what has been noticed for the
> new slot advance feature. This addresses as well the lock problems
> introduced in the new advance code, hopefully the split makes sense to
> others on this thread.
> Once again those only apply to HEAD, please feel free to ping me if you
> would like versions for back-branches (or anybody picking up those
> patches).

And of course I found a typo just after sending those.. Please use the
attached ones instead.
--
Michael

Attachment Content-Type Size
0001-Fix-and-document-lock-handling-for-in-memory-replica.patch text/x-diff 5.8 KB
0002-Fix-a-couple-of-bugs-with-replication-slot-advancing.patch text/x-diff 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2018-06-01 20:36:24 Re: Add CONTRIBUTING.md
Previous Message Manuel Kniep 2018-06-01 19:11:10 Re: PATCH pass PGOPTIONS to pg_regress