Re: pg_receivewal: remove extra conn = NULL; in StreamLog

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_receivewal: remove extra conn = NULL; in StreamLog
Date: 2021-09-02 11:19:34
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 1 Sep 2021, at 10:58, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>>> It seems there's a redundant assignment statement conn = NULL in
>>> pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
>>> Thoughts?
>> Agreed, while harmless this is superfluous since conn is already set to NULL
>> after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
>> Unless there are objections I’ll apply this tomorrow or Monday.
> Thanks for picking this up. I added this to CF to not lose it in the
> wild -

Pushed to master, and entry closed. Thanks.

Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2021-09-02 11:33:22 Re: [BUG]Update Toast data failure in logical replication
Previous Message Daniel Gustafsson 2021-09-02 11:18:47 Re: Online verification of checksums