Re: pg_getaddrinfo_all() with hintp=NULL

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_getaddrinfo_all() with hintp=NULL
Date: 2025-11-12 23:19:58
Message-ID: 7B7A08AB-7B09-4940-80A2-8AFBA402DA4B@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 12 Nov 2025, at 09:46, Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru> wrote:

> I added a comment to pg_freeaddrinfo_all.
> I don't think it made sense to comment that hint_ai_family simply shouldn't be equal to AF_UNIX,
> so I specified that if the original hints were NULL, hint_ai_family should be equal to AF_UNSPEC.

Agreed.

It's still not clear to ne that we should make pg_getaddr_info() mimic the API
of getaddrinfo since it's not a thin wrapper over getaddrinfo. The alternative
option would be to return EAI_FAIL on a null hint and force the caller to
provide an AF_UNSPEC if that is what is indeed asked for.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeremy Schneider 2025-11-12 23:51:13 Re: another autovacuum scheduling thread
Previous Message Daniel Gustafsson 2025-11-12 23:12:19 Re: Extended test coverage and docs for SSL passphrase commands