Re: Update our timezone code to IANA tzcode2026b

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Update our timezone code to IANA tzcode2026b
Date: 2026-07-11 14:52:05
Message-ID: 79c6cf48-2154-44d7-aed6-799c518a5c94@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01.06.26 02:55, Tom Lane wrote:
> I wrote:
>> Here's a patch to do $SUBJECT.
>
> cfbot didn't like v1 too much, here's a v2.

I know you have already reported this upstream, but here are some
patches to silence the resulting warnings on MSVC.

Patch 0001 just silences the warnings using pragmas.

Patch 0002 is to silence the "unary minus operator applied to unsigned
type" warning globally for PostgreSQL. AFAICT, there is no equivalent
warning available on gcc or clang, so this would remain a trap on MSVC.

Patch 0003 is to silence the cross-enum comparison warnings using casts
(as you had suggested to upstream). I confirmed that this works in a
small test case on Compiler Explorer (godbolt.org) but if I push this
branch to GitHub Actions CI, the warning remains, so I don't know about
this one.

Attachment Content-Type Size
0001-Fix-MSVC-warnings-from-new-timezone-code.patch text/plain 1.7 KB
0002-Disable-MSVC-warning-C4146-globally.patch text/plain 2.0 KB
0003-Use-a-different-trick-to-silence-warnings-about-cros.patch text/plain 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2026-07-11 15:12:35 Re: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server
Previous Message cca5507 2026-07-11 14:50:46 Re: Do not lock tables in get_tables_to_repack