| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Update our timezone code to IANA tzcode2026b |
| Date: | 2026-07-11 15:18:44 |
| Message-ID: | 2993217.1783783124@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> I know you have already reported this upstream, but here are some
> patches to silence the resulting warnings on MSVC.
Since Eggert doesn't seem to want to do anything about these,
I was planning on just ignoring them (and have already adjusted
my warning-scraping script to do so). I don't think inserting
diffs from tzdb upstream is a good tradeoff, so I definitely
don't like your 0001. I'd be okay with 0002's solution (suppress
the unary-minus complaint globally). I might hold my nose for
0003, but you say it doesn't seem to work, so ...
(BTW, the links cited in the tzdb thread suggest that whether
MSVC will warn about 0003's fix depend on how recent it is.
So maybe if we got a newer MSVC into our CI infrastructure,
it'd work?)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Jeff Davis | 2026-07-11 15:12:35 | Re: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server |