| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: longfin missing gssapi_ext.h |
| Date: | 2023-04-12 16:37:26 |
| Message-ID: | 79A74001-61EB-467C-988A-424C9305BD94@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Apr 2023, at 16:55, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>
> Greetings,
>
> * Daniel Gustafsson (daniel(at)yesql(dot)se) wrote:
>>> On 12 Apr 2023, at 16:33, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>>> Sure, reworked that way and attached.
>>
>> While not changed in this hunk, does the comment regarding Heimdal still apply?
>>
>> @@ -918,6 +919,7 @@ pg_GSS_recvauth(Port *port)
>> int mtype;
>> StringInfoData buf;
>> gss_buffer_desc gbuf;
>> + gss_cred_id_t delegated_creds;
>>
>> /*
>> * Use the configured keytab, if there is one. Unfortunately, Heimdal
>
> Good catch. No, it doesn't. I'm not anxious to actually change that
> code at this point but we could certainly consider changing it in the
> future. I'll update this comment (and the identical one in
> secure_open_gssapi) accordingly.
Sounds like a good plan.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2023-04-12 16:38:06 | Re: Direct I/O |
| Previous Message | Mark Dilger | 2023-04-12 16:31:39 | Re: [PATCH] Allow Postgres to pick an unused port to listen |