| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: statistics for shared catalogs not updated when autovacuum is off |
| Date: | 2016-05-25 19:59:01 |
| Message-ID: | 7989.1464206341@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, May 24, 2016 at 3:52 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> True, although I'm not sure if adding a dependency on IsSharedRelation()
>> here is a good thing. In any case, you took the dependency too far ...
> OK. It seemed more simple to me to have the dependency on catalog.h to
> avoid two lookups. But I won't fight for it either.
Well, it might be worth doing, but I think it's a distinct patch.
> I am going to look at the second patch you sent.
OK. I'm going to work on replacing the DBWriteRequest structure with
an OID list, and on improving the comments some more, but I don't
anticipate further functional changes.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Piotr Stefaniak | 2016-05-25 20:01:53 | Re: pg_bsd_indent - improvements around offsetof and sizeof |
| Previous Message | Michael Paquier | 2016-05-25 19:48:53 | Re: statistics for shared catalogs not updated when autovacuum is off |