Re: report expected contrecord size

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: report expected contrecord size
Date: 2020-09-03 21:31:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> A pretty minor issue: when reporting that WAL appears invalid because
> contrecord length doesn't match, we may as well print to the server log
> the value that we're expecting. Patch attached.


+ (long long) (total_len - gotlen),

just to be sure about what's getting casted to what. Otherwise +1.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-09-03 21:36:02 Re: Maximum password length
Previous Message Tom Lane 2020-09-03 21:29:35 Re: Parallel worker hangs while handling errors.