Re: [PATCHES] GIN improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] GIN improvements
Date: 2008-07-24 17:01:35
Message-ID: 7913.1216918895@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
>> * There is a bigger race condition, which is that after a scan has
>> returned a tuple from a pending page, vacuum could move the index entry
>> into the main index structure, and then that same scan could return that
>> same index entry a second time. This is a no-no, and I don't see any easy
>> fix.

> Hmm, isn't it allowed for indexes? At least GiST has this behaviour from its
> birth date.

Really? Then GiST needs to be fixed too. Otherwise you risk having
queries return the same row twice. A bitmap indexscan plan would mask
such an index bug ... but a plain indexscan won't.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-07-24 17:09:24 Re: Extending grant insert on tables to sequences
Previous Message Jaime Casanova 2008-07-24 16:17:07 Re: Extending grant insert on tables to sequences

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-07-24 17:09:24 Re: Extending grant insert on tables to sequences
Previous Message Jaime Casanova 2008-07-24 16:17:07 Re: Extending grant insert on tables to sequences