Re: Misleading errors with column references in default expressions and partition bounds

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Misleading errors with column references in default expressions and partition bounds
Date: 2019-03-29 02:55:48
Message-ID: 78b80dc8-e266-dc50-f660-9fdeccc4af4f@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019/03/28 21:14, Michael Paquier wrote:
> On Wed, Mar 27, 2019 at 12:13:16PM +0900, Michael Paquier wrote:
>> ParseExprKind is an enum, so listing all the options without the
>> default has the advantage to generate a warning if somebody adds a
>> value. This way anybody changing this code will need to think about
>> it.
>
> A bit late, but committed without the case/default.
>
>>> ... The value
>>> is any variable-free expression (in particular, cross-references
>>> to other columns in the current table are not allowed). Subqueries
>>> are not allowed either.
>>
>> Okay, I think I see your point here. That sounds sensible.
>
> And I have used this suggestion from Tom as well for the docs.

Thanks Michael for taking care of this.

Regards,
Amit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2019-03-29 03:36:45 RE: Timeout parameters
Previous Message Corey Huinker 2019-03-29 02:53:38 Re: Syntax diagrams in user documentation