Re: reducing isolation tests runtime

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: reducing isolation tests runtime
Date: 2018-01-25 15:01:19
Message-ID: 7752.1516892479@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>>> On the subject of test total time, we could paralelize isolation tests.

>> BTW, one small issue there is that the reason the timeouts test is so
>> slow is that we have to use multi-second timeouts to be sure slower
>> buildfarm critters (eg valgrind animals) will get the expected results.
>> So I'm worried that if the machine isn't otherwise idle, we will get
>> random failures.

> I think we could solve this by putting in the same parallel group only
> slow tests that mostly sleeps, ie. nothing that would monopolize CPU for
> long enough to cause a problem. Concretely:
> test: timeouts tuplelock-update deadlock-hard deadlock-soft-2

OK, but there'd better be a comment there explaining the concern
very precisely, or somebody will break it.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-01-25 16:15:15 pgsql: Update documentation to mention huge pages on other OSes
Previous Message Peter Eisentraut 2018-01-25 14:43:43 pgsql: Remove use of byte-masking macros in record_image_cmp

Browse pgsql-hackers by date

  From Date Subject
Next Message Rady, Doug 2018-01-25 15:05:52 Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
Previous Message Alvaro Herrera 2018-01-25 14:41:38 Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem