Re: pg_bsd_indent and -Wimplicit-fallthrough

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_bsd_indent and -Wimplicit-fallthrough
Date: 2020-05-15 07:17:54
Message-ID: 771FDD4B-F645-4138-A83A-79C99E436322@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 May 2020, at 08:28, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Fri, May 15, 2020 at 8:03 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

>> Something like the attached is fine to take care of those warnings,
>> but what's our current patching policy for this tool?
>
> The patch looks good to me. It looks like we already have custom
> patches, so +1 to applying it.

Shouldn't we try and propose it to upstream first to minimize our diff?

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-05-15 08:25:08 Re: pg_regress cleans up tablespace twice.
Previous Message Fujii Masao 2020-05-15 06:55:19 Re: PG 13 release notes, first draft