Re: [PATCH] Incremental sort (was: PoC: Partial sort)

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, James Coleman <jtc331(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: 2020-03-22 22:02:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 3/21/20 1:56 AM, Tomas Vondra wrote:
> I've looked at v38 but it seems it's a bit broken by some recent explain
> changes (mostly missing type in declarations). Attached is v39 fixing
> those issues, and including a bunch of fixes based on a review - most of
> the changes is in comments, so I've instead kept them in separate "fix"
> patches after each part.
> In general I'm mostly happy with the current shape of the patch, and
> unless there are some objections I'd like to get some of it committed
> sometime next week.


I haven't had any time to look at the patch yet but when compiling it
and running the tests GCC gave me a warning. The tests passed btw.

gcc (Debian 8.3.0-6) 8.3.0

explain.c: In function ‘show_incremental_sort_group_info’:
explain.c:2772:39: warning: passing argument 2 of ‘lappend’ discards
‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
methodNames = lappend(methodNames, sortMethodName);
In file included from ../../../src/include/access/xact.h:20,
from explain.c:16:
../../../src/include/nodes/pg_list.h:509:14: note: expected ‘void *’ but
argument is of type ‘const char *’
extern List *lappend(List *list, void *datum);
explain.c:2772:39: warning: passing 'const char *' to parameter of type
'void *' discards qualifiers
methodNames = lappend(methodNames, sortMethodName);
../../../src/include/nodes/pg_list.h:509:40: note: passing argument to
parameter 'datum' here
extern List *lappend(List *list, void *datum);

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-22 22:16:49 Re: Some improvements to numeric sqrt() and ln()
Previous Message James Coleman 2020-03-22 21:28:05 Re: optimisation? collation "C" sorting for GroupAggregate for all deterministic collations