Re: Some improvements to numeric sqrt() and ln()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: nospam-pg-abuse(at)bloodgate(dot)com
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Some improvements to numeric sqrt() and ln()
Date: 2020-03-22 22:16:49
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tels <nospam-pg-abuse(at)bloodgate(dot)com> writes:
> This can be reformulated as:
> + * If r < 0 Then
> + * Let r = r + s
> + * Let s = s - 1
> + * Let r = r + s

Here's a v3 that

* incorporates Tels' idea;

* improves some of the comments (IMO anyway, though some are clear typos);

* adds some XXX comments about things that could be further improved
and/or need better explanations.

I also ran it through pgindent, just cause I'm like that.

With resolutions of the XXX items, I think this'd be committable.

regards, tom lane

Attachment Content-Type Size
numeric-sqrt-v3.patch text/x-diff 22.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-03-22 22:23:32 Re: Index Skip Scan
Previous Message Andreas Karlsson 2020-03-22 22:02:46 Re: [PATCH] Incremental sort (was: PoC: Partial sort)