Re: [PATCH] quiet conversion warning in DatumGetFloat4

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Chapman Flack <chap(at)anastigmatix(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] quiet conversion warning in DatumGetFloat4
Date: 2017-05-31 05:57:09
Message-ID: 7642.1496210229@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Chapman Flack <chap(at)anastigmatix(dot)net> writes:
> On 05/31/17 01:26, Tom Lane wrote:
>> Hm. I think it would be better to use DatumGetInt32 here. Arguably,
>> direct use of GET_4_BYTES and its siblings should only appear in
>> DatumGetFoo macros.

> Like so?

Looks promising offhand, but I'm too tired to check in detail right now.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kuntal Ghosh 2017-05-31 06:17:02 Re: "create publication..all tables" ignore 'partition not supported' error
Previous Message Chapman Flack 2017-05-31 05:55:11 Re: [PATCH] quiet conversion warning in DatumGetFloat4