Re: [PATCH] quiet conversion warning in DatumGetFloat4

From: Chapman Flack <chap(at)anastigmatix(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] quiet conversion warning in DatumGetFloat4
Date: 2017-05-31 05:55:11
Message-ID: 592E5ABF.8070706@anastigmatix.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/31/17 01:26, Tom Lane wrote:
> Hm. I think it would be better to use DatumGetInt32 here. Arguably,
> direct use of GET_4_BYTES and its siblings should only appear in
> DatumGetFoo macros.

Like so? These are the 4 sites where {GET,SET}_n_BYTES got introduced
in 14cca1b (for consistency, though only the GET_4 case produces warnings).

-Chap

Attachment Content-Type Size
quiet-conversion-warning-getfloat4-v2.patch text/x-patch 820 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-05-31 05:57:09 Re: [PATCH] quiet conversion warning in DatumGetFloat4
Previous Message Tom Lane 2017-05-31 05:26:30 Re: [PATCH] quiet conversion warning in DatumGetFloat4