Re: Fix comment in btree_gist--1.8--1.9.sql

On 7/9/25 08:51, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> On Tue, Jul 08, 2025 at 04:49:30PM -0700, Paul Jungwirth wrote:
>>> A related question: In the v18 release we are adding two upgrade files:
>>> btree_gist--1.7--1.8.sql and btree_gist--1.8-1.9.sql. Why not collapse them
>>> into one? Technically we briefly had btree_gist--1.7--1.8.sql in 17devel,
>>> but it was reverted before release. Would you like a patch combining these
>>> files? Is it too late for that?
>
>> It would be too late once the branch is officially released, and we
>> are still in a position where it is possible to combine both. Let's
>> do so for REL_18_STABLE, having two upgrade paths for a single major
>> version is just extra work for no benefit.
>
> +1 for merging those two while we still can.

Patch attached, based on REL_18_STABLE.

I considered putting the sortsupport functions first, since they have a lower support function
number, but I thought defining them in the same order as we've been doing was a tiny bit safer.
Maybe that is superstitious.

Yours,

--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com