Re: Fix comment in btree_gist--1.8--1.9.sql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Paul Jungwirth <pj(at)illuminatedcomputing(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix comment in btree_gist--1.8--1.9.sql
Date: 2025-07-09 17:52:08
Message-ID: 1329465.1752083528@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Paul Jungwirth <pj(at)illuminatedcomputing(dot)com> writes:
> On 7/9/25 08:51, Tom Lane wrote:
>> +1 for merging those two while we still can.

> Patch attached, based on REL_18_STABLE.

> I considered putting the sortsupport functions first, since they have a lower support function
> number, but I thought defining them in the same order as we've been doing was a tiny bit safer.
> Maybe that is superstitious.

Yeah, I'd be inclined to swap them. I dislike code that has no
ordering principle other than feature development order.

LGTM other than that nit. Michael, do you want to do the
honors, or shall I?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-07-09 17:53:48 Re: Horribly slow pg_upgrade performance with many Large Objects
Previous Message Andres Freund 2025-07-09 17:46:29 Re: [PoC] Federated Authn/z with OAUTHBEARER