Re: Updating line length guidelines

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Updating line length guidelines
Date: 2017-08-20 16:29:39
Message-ID: 7581a525-a7f8-d47d-0e5e-fb48f7af27ea@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/20/2017 07:49 AM, Andres Freund wrote:
> Hi,
>
> We currently still have the guideline that code should fit into an 80
> character window. But an increasing amount of the code, and code
> submissions, don't adhere to that (e.g. copy.c, which triggered me to
> write this email). And I mean outside of accepted "exceptions" like
> error messages. And there's less need for such a relatively tight limit
> these days. Perhaps we should up the guideline to 90 or 100 chars?

Considering the prominence of high resolution monitors and the fact that
we don't really review patches (outside of commentary) in email much
anymore, it seems that may even be a bit archaic. On my standard FHD
screen using a standard size font I have a line length of 210 before I wrap.

Sincerely,

JD

>
> Greetings,
>
> Andres Freund
>
>

--
Command Prompt, Inc. || http://the.postgres.company/ || @cmdpromptinc

PostgreSQL Centered full stack support, consulting and development.
Advocate: @amplifypostgres || Learn: https://pgconf.us
***** Unless otherwise stated, opinions are my own. *****

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-08-20 16:32:30 Re: Updating line length guidelines
Previous Message Andres Freund 2017-08-20 14:49:25 Updating line length guidelines