| From: | David Geier <geidav(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw fails to see that array type belongs to extension |
| Date: | 2024-01-15 13:24:38 |
| Message-ID: | 754ca2af-6d1d-49b7-935d-bfd1c1a75c4c@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I realized that ALTER EXTENSION foo ADD TYPE _bar does pretty much the
same via ExecAlterExtensionContentsStmt(). So the code in the patch
seems fine.
On 1/8/24 12:21, David Geier wrote:
> The attached patch just adds a 2nd dependency between the array type
> and the extension, using recordDependencyOnCurrentExtension(). It
> seems like that the other internal dependency on the element type must
> stay? If that seems reasonable I can add a test to
> modules/test_extensions. Can extensions in contrib use test extension
> in their own tests? It looks like postgres_fdw doesn't test any of the
> shippability logic.
>
--
David Geier
(ServiceNow)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2024-01-15 13:26:08 | Re: Add test module for Table Access Method |
| Previous Message | Alena Rybakina | 2024-01-15 13:21:05 | Re: POC: GROUP BY optimization |