| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "vignesh C" <vignesh21(at)gmail(dot)com>, "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Dilip Kumar" <dilipbalaut(at)gmail(dot)com>, "shveta(dot)malik(at)gmail(dot)com" <shveta(dot)malik(at)gmail(dot)com>, "Peter Smith" <smithpb2250(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Include schema-qualified names in publication error messages. |
| Date: | 2026-05-07 12:27:09 |
| Message-ID: | 74ce651a-548b-4745-8dc4-6d8b4e143ced@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 7, 2026, at 3:00 AM, vignesh C wrote:
>
> * v5-0001-Include-schema-qualified-names-in-EXCEPT-clause-e.patch
> * v5-0002-Include-schema-qualified-names-in-non-EXCEPT-publ.patch
Regarding v5-0002:
check_publication_add_relation(PublicationRelInfo *pri)
{
Relation targetrel = pri->relation;
- const char *relname;
const char *errormsg;
if (pri->except)
- {
- relname = get_relation_qualified_name(targetrel);
errormsg = gettext_noop("cannot specify relation \"%s\" in the publication EXCEPT clause");
- }
else
- {
- relname = RelationGetRelationName(targetrel);
errormsg = gettext_noop("cannot add relation \"%s\" to publication");
- }
Why did you remove relname variable? In addition to reduce the patch size, you
avoid increasing the number of modifications if the function
get_relation_qualified_name is modified in the future.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2026-05-07 12:29:19 | Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION |
| Previous Message | Euler Taveira | 2026-05-07 12:19:46 | Re: Include schema-qualified names in publication error messages. |