| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "shveta(dot)malik(at)gmail(dot)com" <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | "vignesh C" <vignesh21(at)gmail(dot)com>, "Dilip Kumar" <dilipbalaut(at)gmail(dot)com>, "Peter Smith" <smithpb2250(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "shveta malik" <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Include schema-qualified names in publication error messages. |
| Date: | 2026-05-07 12:19:46 |
| Message-ID: | 3a8cc8db-dd10-4835-bdea-a51e70402e18@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 7, 2026, at 7:07 AM, Amit Kapila wrote:
>
> That makes sense. I have changed that in the attached and made slight
> modifications in the comments. How about attached?
>
One minor suggestion is to rename get_relation_qualified_name to
get_qualified_relation_name. If we want to reuse this new function
get_relation_qualified_name into other places, shouldn't we move this function
to lsyscache.c? There are places like matview.c that could benefit from this new
function.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2026-05-07 12:27:09 | Re: Include schema-qualified names in publication error messages. |
| Previous Message | Andrey Borodin | 2026-05-07 11:57:28 | Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race |