| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility. |
| Date: | 2018-11-21 09:54:21 |
| Message-ID: | 74aafd48-1a2a-37fb-aab8-ffaed70a2b0f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 21/11/2018 09:20, Christoph Berg wrote:
> Re: Andres Freund 2018-11-21 <E1gPG3j-0003cy-03(at)gemulon(dot)postgresql(dot)org>
>> The biggest user of WITH OID columns was postgres' catalog. This
>> commit changes all 'magic' oid columns to be columns that are normally
>> declared and stored.
>
> postgres=# \d+ pg_class
> [...]
> Indexe:
> "pg_class_oid_index" UNIQUE, btree (oid)
>
> Now that oid is a proper column, shouldn't that be a PRIMARY KEY?
> (Just for the looks.)
This is an independent consideration. There was nothing before that
prevented an index on an oid column from being a primary key that isn't
still there.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-11-21 18:04:58 | pgsql: Fix PartitionDispatchData vertical whitespace |
| Previous Message | Christoph Berg | 2018-11-21 08:27:31 | Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-11-21 10:23:52 | Re: speeding up planning with partitions |
| Previous Message | Iwata, Aya | 2018-11-21 09:53:46 | RE: libpq debug log |