|From:||"Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>|
|To:||'Jacob Champion' <pchampion(at)pivotal(dot)io>|
|Cc:||PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, "nagata(at)sraoss(dot)co(dot)jp" <nagata(at)sraoss(dot)co(dot)jp>, "peter(dot)eisentraut(at)2ndquadrant(dot)com" <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||RE: libpq debug log|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Hi Jacob san,
Thank you for your comment! And sorry for late reply...
> Couple additional thoughts from a read-through of the patch:
> - PQtrace() and the new trace-logging machinery overlap in some places but
> not others -- and if both are set, PQtrace() will take precedence.
> It seems like the two should not be separate.
I understand. This log is acquired for the purpose of investigating the cause part (server side or application side) when performance is bad.
So I will search whether getting other place of PQtrace() is necessary or not.
And I will reply after the research, please wait for a while a little.
> - It isn't immediately clear to me how the new information in the logs is
> intended to be used in concert with the old information. Maybe this goes back
> to the comments by Tom and Robert higher in the thread -- that an overhaul
> of the PQtrace system is due. This patch as presented would make things a
> little worse before they got better, I think.
> That said, I think the overall idea -- application performance information
> that can be enabled via the environment, without requiring debugging
> privileges on a machine or the need to manually correlate traces made by other
> applications -- is a good one, and something I would use.
Thank you. I think so, too. Some applications cannot be stopped to add the PQtrace() code.
|Next Message||Peter Eisentraut||2018-11-21 09:54:21||Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.|
|Previous Message||Iwata, Aya||2018-11-21 09:03:02||RE: libpq debug log|