Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alexey Bashtanov <bashtanov(at)imap(dot)cc>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING
Date: 2020-03-18 02:58:54
Message-ID: 7354.1584500334@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I have implemented the ideas above in the attached patch. I have
> synchronized the syntax to match SELECT, and synchronized the paragraphs
> describing the item.

I think that the DELETE synopsis should look like

[ USING <replaceable class="parameter">from_item</replaceable> [, ...] ]

so that there's not any question which part of the SELECT syntax we're
talking about. I also think that the running text in both cases should
say in exactly these words "from_item means the same thing as it does
in SELECT"; the wording you propose still seems to be dancing around
the point, leaving readers perhaps not quite sure about what is meant.

In the DELETE case you could alternatively say "using_item means the same
thing as from_item does in SELECT", but that doesn't really seem like an
improvement to me.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-03-18 03:06:41 Re: adding partitioned tables to publications
Previous Message Andy Fan 2020-03-18 02:56:58 Re: [PATCH] Erase the distinctClause if the result is unique by definition