| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | surya poondla <suryapoondla4(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com> |
| Subject: | Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed |
| Date: | 2026-11-20 09:46:17 |
| Message-ID: | 7304dd19-fd93-48b1-afea-6252a8691ba2@vondra.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/20/26 03:44, Fujii Masao wrote:
> On Fri, Nov 20, 2026 at 10:54 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>> # Prefetching requires posix_fadvise(). Without it, the server rejects the
>> # non-zero maintenance_io_concurrency this test relies on.
>> if (!check_pg_config("#define HAVE_POSIX_FADVISE 1"))
>> {
>> plan skip_all => 'posix_fadvise() not supported by this platform';
>> }
>
> This check seems to skip the test on macOS because posix_fadvise() is not
> supported there. But, v18 and later have a platform-specific prefetch
> for macOS, so maintenance_io_concurrency = 1 can be set there.
>
> So, this check might be insufficient for macOS?
>
I'm planning to add the skip only on 15-17, so that on 18+ the test
keeps running everywhere. I believe that should still work even on
macos, but I've only tested it on Linux built without fadvise by:
./configure ac_cv_func_posix_fadvise=no
regards
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-11-20 10:04:52 | Re: Parallel GIN, BRIN builds fail to maintain ii_BrokenHotChain |
| Previous Message | Michael Paquier | 2026-11-20 09:27:10 | Re: Report buffer access strategies in EXPLAIN |