Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: surya poondla <suryapoondla4(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>
Subject: Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed
Date: 2026-11-20 02:44:13
Message-ID: CAHGQGwH2M_AGHUisShQ0O6ftmd2k9zowNtc64hO_nA8wAbJDnQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 20, 2026 at 10:54 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> # Prefetching requires posix_fadvise(). Without it, the server rejects the
> # non-zero maintenance_io_concurrency this test relies on.
> if (!check_pg_config("#define HAVE_POSIX_FADVISE 1"))
> {
> plan skip_all => 'posix_fadvise() not supported by this platform';
> }

This check seems to skip the test on macOS because posix_fadvise() is not
supported there. But, v18 and later have a platform-specific prefetch
for macOS, so maintenance_io_concurrency = 1 can be set there.

So, this check might be insufficient for macOS?

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Chao Li 2026-11-20 02:40:49 Re: Table AM callback for logical decoding support (REPACK CONCURRENTLY)